Icon View Incident Report

Minor Minor
Reported By: Wolfgang Klein
Reported On: 6/13/2014
For: Version 2.17 Build 1
# 4102 64-bit Issues with ElevateDB Manager Source Code

I've found two type-casts from Self to Integer in "main.pas":

procedure TManagerObject.Sort(Recurse: Boolean=False);
begin
if (FNode <> nil) then
FNode.CustomSort(nil,Integer(Self),Recurse);
MainForm.PropertiesListView.CustomSort(nil,Integer(Self));
end;

Should that be something like "IntPtr(Self)"?


Is the type-cast "Integer(List.Objects" correct?

function CompareSections(List: TStringList; Index1, Index2: Integer): Integer;
begin
if (Integer(List.Objects[Index1]) < Integer(List.Objects[Index2])) then
Result:=CMP_LESS
else if (Integer(List.Objects[Index1]) > Integer(List.Objects[Index2])) then
Result:=CMP_GREATER
else
Result:=CMP_EQUAL;
end;


Best regards
Wolfgang Klein




Comments Comments
There were a couple of other issues with references/pointers being cast to/from 32-bit integers, and all have been corrected.


Resolution Resolution
Fixed Problem on 6/20/2014 in version 2.18 build 1


Products Affected Products Affected
ElevateDB Additional Software and Utilities

Image